perf(neon_notes): do not use the spread operator for building lists

Signed-off-by: Nikolas Rimikis <leptopoda@users.noreply.github.com>

packages/neon/neon_news/lib/widgets/feeds_view.dart

@@ -57,12 +57,11 @@ class NewsFeedsView extends StatelessWidget {
           value: NewsFeedAction.rename,
           child: Text(NewsLocalizations.of(context).actionRename),
         ),
-        if (folders.isNotEmpty) ...[
+        if (folders.isNotEmpty)
           PopupMenuItem(
             value: NewsFeedAction.move,
             child: Text(NewsLocalizations.of(context).actionMove),
           ),
-        ],
       ],
       onSelected: (final action) async {
         switch (action) {

packages/neon/neon_notes/lib/dialogs/create_note.dart

@@ -60,9 +60,11 @@ class _NotesCreateNoteDialogState extends State<NotesCreateNoteDialog> {
                         onRetry: widget.bloc.refresh,
                       ),
                     ),
-                  if (widget.category == null && notes.isLoading)
+                  if (widget.category == null)
-                    const Center(
+                    Center(
-                      child: NeonLinearProgressIndicator(),
+                      child: NeonLinearProgressIndicator(
+                        visible: notes.isLoading,
+                      ),
                     ),
                   if (widget.category == null && notes.hasData)
                     NotesCategorySelect(

packages/neon/neon_notes/lib/dialogs/select_category.dart

@@ -36,18 +36,19 @@ class _NotesSelectCategoryDialogState extends State<NotesSelectCategoryDialog> {
               child: Column(
                 crossAxisAlignment: CrossAxisAlignment.end,
                 children: [
-                  Center(
+                  if (notes.hasError)
-                    child: NeonError(
+                    Center(
-                      notes.error,
+                      child: NeonError(
-                      onRetry: widget.bloc.refresh,
+                        notes.error,
+                        onRetry: widget.bloc.refresh,
+                      ),
                     ),
-                  ),
                   Center(
                     child: NeonLinearProgressIndicator(
                       visible: notes.isLoading,
                     ),
                   ),
-                  if (notes.hasData) ...[
+                  if (notes.hasData)
                     NotesCategorySelect(
                       categories: notes.requireData.map((final note) => note.category).toSet().toList(),
                       initialValue: widget.initialCategory,
@@ -56,7 +57,6 @@ class _NotesSelectCategoryDialogState extends State<NotesSelectCategoryDialog> {
                       },
                       onSubmitted: submit,
                     ),
-                  ],
                   ElevatedButton(
                     onPressed: submit,
                     child: Text(NotesLocalizations.of(context).noteSetCategory),

packages/neon/neon_notes/lib/widgets/notes_view.dart

@@ -45,20 +45,20 @@ class NotesView extends StatelessWidget {
             RelativeTime(
               date: DateTime.fromMillisecondsSinceEpoch(note.modified * 1000),
             ),
-            if (note.category.isNotEmpty) ...[
+            if (note.category.isNotEmpty)
-              const SizedBox(
+              Padding(
-                width: 8,
+                padding: const EdgeInsets.only(top: 8),
-              ),
+                child: Icon(
-              Icon(
+                  MdiIcons.tag,
-                MdiIcons.tag,
+                  size: smallIconSize,
-                size: smallIconSize,
+                  color: NotesCategoryColor.compute(note.category),
-                color: NotesCategoryColor.compute(note.category),
+                ),
               ),
-              const SizedBox(
+            if (note.category.isNotEmpty)
-                width: 2,
+              Padding(
+                padding: const EdgeInsets.only(top: 2),
+                child: Text(note.category),
               ),
-              Text(note.category),
-            ],
           ],
         ),
         trailing: IconButton(