Merge pull request #426 from Leptopoda/cleanup/neon_exception

neon: cleanup NeonException

packages/neon/neon/lib/src/widgets/exception.dart

@@ -25,7 +25,7 @@ class NeonException extends StatelessWidget {
         action: details.isUnauthorized
             ? SnackBarAction(
                 label: AppLocalizations.of(context).loginAgain,
-                onPressed: () async => _openLoginPage(context),
+                onPressed: () => _openLoginPage(context),
               )
             : null,
       ),
@@ -33,20 +33,25 @@ class NeonException extends StatelessWidget {
   }
 
   @override
-  Widget build(final BuildContext context) => exception == null
+  Widget build(final BuildContext context) {
-      ? Container()
+    if (exception == null) {
-      : Container(
+      return const SizedBox();
-          padding: !onlyIcon ? const EdgeInsets.all(5) : null,
+    }
-          child: Builder(
+
-            builder: (final context) {
     final details = _getExceptionDetails(context, exception);
+    final color = this.color ?? Theme.of(context).colorScheme.error;
 
     final errorIcon = Icon(
       Icons.error_outline,
       size: iconSize ?? 30,
-                color: color ?? Colors.red,
+      color: color,
     );
 
+    final message =
+        details.isUnauthorized ? AppLocalizations.of(context).loginAgain : AppLocalizations.of(context).actionRetry;
+
+    final onPressed = details.isUnauthorized ? () => _openLoginPage(context) : onRetry;
+
     if (onlyIcon) {
       return Semantics(
         tooltip: details.text,
@@ -57,21 +62,15 @@ class NeonException extends StatelessWidget {
             horizontal: VisualDensity.minimumDensity,
             vertical: VisualDensity.minimumDensity,
           ),
-                    tooltip: details.isUnauthorized
+          tooltip: message,
-                        ? AppLocalizations.of(context).loginAgain
+          onPressed: onPressed,
-                        : AppLocalizations.of(context).actionRetry,
-                    onPressed: () async {
-                      if (details.isUnauthorized) {
-                        _openLoginPage(context);
-                      } else {
-                        onRetry();
-                      }
-                    },
         ),
       );
     }
 
-              return Column(
+    return Padding(
+      padding: const EdgeInsets.all(5),
+      child: Column(
         mainAxisAlignment: MainAxisAlignment.center,
         children: [
           Row(
@@ -85,28 +84,20 @@ class NeonException extends StatelessWidget {
                 child: Text(
                   details.text,
                   style: TextStyle(
-                            color: color ?? Colors.red,
+                    color: color,
                   ),
                 ),
               ),
             ],
           ),
-                  if (details.isUnauthorized) ...[
           ElevatedButton(
-                      onPressed: () async => _openLoginPage(context),
+            onPressed: onPressed,
-                      child: Text(AppLocalizations.of(context).loginAgain),
+            child: Text(message),
           ),
-                  ] else ...[
-                    ElevatedButton(
-                      onPressed: onRetry,
-                      child: Text(AppLocalizations.of(context).actionRetry),
-                    ),
-                  ],
         ],
-              );
-            },
       ),
     );
+  }
 
   static _ExceptionDetails _getExceptionDetails(final BuildContext context, final dynamic exception) {
     if (exception is String) {