Browse Source

Merge pull request #739 from nextcloud/feature/source-code-issue-tracker-links

feat(neon,app): Add links to the source code and issue tracker
pull/743/head
Kate 1 year ago committed by GitHub
parent
commit
d383943b72
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 2
      packages/app/lib/branding.dart
  2. 4
      packages/neon/neon/lib/l10n/en.arb
  3. 12
      packages/neon/neon/lib/l10n/localizations.dart
  4. 6
      packages/neon/neon/lib/l10n/localizations_en.dart
  5. 31
      packages/neon/neon/lib/src/pages/settings.dart
  6. 8
      packages/neon/neon/lib/src/theme/branding.dart

2
packages/app/lib/branding.dart

@ -17,6 +17,8 @@ const branding = Branding(
'assets/logo.svg.vec', 'assets/logo.svg.vec',
), ),
), ),
sourceCodeURL: 'https://github.com/nextcloud/neon',
issueTrackerURL: 'https://github.com/nextcloud/neon/issues',
legalese: 'Copyright © 2023, provokateurin\nUnder GPLv3 license', legalese: 'Copyright © 2023, provokateurin\nUnder GPLv3 license',
); );

4
packages/neon/neon/lib/l10n/en.arb

@ -180,5 +180,7 @@
}, },
"accountOptionsInitialApp": "App to show initially", "accountOptionsInitialApp": "App to show initially",
"accountOptionsAutomatic": "Automatic", "accountOptionsAutomatic": "Automatic",
"licenses": "Licenses" "licenses": "Licenses",
"sourceCode": "Source code",
"issueTracker": "Report a bug or request a feature"
} }

12
packages/neon/neon/lib/l10n/localizations.dart

@ -688,6 +688,18 @@ abstract class AppLocalizations {
/// In en, this message translates to: /// In en, this message translates to:
/// **'Licenses'** /// **'Licenses'**
String get licenses; String get licenses;
/// No description provided for @sourceCode.
///
/// In en, this message translates to:
/// **'Source code'**
String get sourceCode;
/// No description provided for @issueTracker.
///
/// In en, this message translates to:
/// **'Report a bug or request a feature'**
String get issueTracker;
} }
class _AppLocalizationsDelegate extends LocalizationsDelegate<AppLocalizations> { class _AppLocalizationsDelegate extends LocalizationsDelegate<AppLocalizations> {

6
packages/neon/neon/lib/l10n/localizations_en.dart

@ -344,4 +344,10 @@ class AppLocalizationsEn extends AppLocalizations {
@override @override
String get licenses => 'Licenses'; String get licenses => 'Licenses';
@override
String get sourceCode => 'Source code';
@override
String get issueTracker => 'Report a bug or request a feature';
} }

31
packages/neon/neon/lib/src/pages/settings.dart

@ -24,6 +24,7 @@ import 'package:neon/src/utils/save_file.dart';
import 'package:neon/src/widgets/exception.dart'; import 'package:neon/src/widgets/exception.dart';
import 'package:package_info_plus/package_info_plus.dart'; import 'package:package_info_plus/package_info_plus.dart';
import 'package:provider/provider.dart'; import 'package:provider/provider.dart';
import 'package:url_launcher/url_launcher_string.dart';
enum SettingsCategories { enum SettingsCategories {
apps, apps,
@ -54,6 +55,7 @@ class _SettingsPageState extends State<SettingsPage> {
final globalOptions = Provider.of<GlobalOptions>(context); final globalOptions = Provider.of<GlobalOptions>(context);
final accountsBloc = Provider.of<AccountsBloc>(context, listen: false); final accountsBloc = Provider.of<AccountsBloc>(context, listen: false);
final appImplementations = Provider.of<Iterable<AppImplementation>>(context); final appImplementations = Provider.of<Iterable<AppImplementation>>(context);
final branding = Branding.of(context);
final appBar = AppBar( final appBar = AppBar(
title: Text(AppLocalizations.of(context).settings), title: Text(AppLocalizations.of(context).settings),
@ -220,6 +222,34 @@ class _SettingsPageState extends State<SettingsPage> {
title: Text(AppLocalizations.of(context).optionsCategoryOther), title: Text(AppLocalizations.of(context).optionsCategoryOther),
key: ValueKey(SettingsCategories.other.name), key: ValueKey(SettingsCategories.other.name),
tiles: <SettingsTile>[ tiles: <SettingsTile>[
if (branding.sourceCodeURL != null)
CustomSettingsTile(
leading: Icon(
Icons.code,
color: Theme.of(context).colorScheme.primary,
),
title: Text(AppLocalizations.of(context).sourceCode),
onTap: () async {
await launchUrlString(
branding.sourceCodeURL!,
mode: LaunchMode.externalApplication,
);
},
),
if (branding.issueTrackerURL != null)
CustomSettingsTile(
leading: Icon(
MdiIcons.textBoxEditOutline,
color: Theme.of(context).colorScheme.primary,
),
title: Text(AppLocalizations.of(context).issueTracker),
onTap: () async {
await launchUrlString(
branding.issueTrackerURL!,
mode: LaunchMode.externalApplication,
);
},
),
CustomSettingsTile( CustomSettingsTile(
leading: Icon( leading: Icon(
MdiIcons.scriptText, MdiIcons.scriptText,
@ -227,7 +257,6 @@ class _SettingsPageState extends State<SettingsPage> {
), ),
title: Text(AppLocalizations.of(context).licenses), title: Text(AppLocalizations.of(context).licenses),
onTap: () async { onTap: () async {
final branding = Branding.of(context);
showLicensePage( showLicensePage(
context: context, context: context,
applicationName: branding.name, applicationName: branding.name,

8
packages/neon/neon/lib/src/theme/branding.dart

@ -12,6 +12,8 @@ class Branding {
const Branding({ const Branding({
required this.name, required this.name,
required this.logo, required this.logo,
this.sourceCodeURL,
this.issueTrackerURL,
this.legalese, this.legalese,
this.showLoginWithNextcloud = true, this.showLoginWithNextcloud = true,
}); });
@ -22,6 +24,12 @@ class Branding {
/// Logo of the app shown on various places in the app. /// Logo of the app shown on various places in the app.
final Widget logo; final Widget logo;
/// The URL where the source code can be seen
final String? sourceCodeURL;
/// The URL where users can report bugs and request features
final String? issueTrackerURL;
/// A string to show in small print. /// A string to show in small print.
/// ///
/// Typically this is a copyright notice shown as the [AboutDialog.applicationLegalese]. /// Typically this is a copyright notice shown as the [AboutDialog.applicationLegalese].

Loading…
Cancel
Save