Browse Source

Rework parse_client_msg to use the non blocking recv return values avoiding the need for an extra wait_read_select

master
Con Kolivas 10 years ago
parent
commit
6c0c7dd7c4
  1. 16
      src/connector.c

16
src/connector.c

@ -343,21 +343,13 @@ static void parse_client_msg(cdata_t *cdata, client_instance_t *client)
json_t *val; json_t *val;
retry: retry:
ret = wait_read_select(client->fd, 0);
if (ret < 1) {
if (!ret)
return;
LOGINFO("Client fd %d disconnected - select fail with bufofs %d ret %d errno %d %s",
client->fd, client->bufofs, ret, errno, ret && errno ? strerror(errno) : "");
invalidate_client(ckp, cdata, client);
return;
}
buflen = PAGESIZE - client->bufofs; buflen = PAGESIZE - client->bufofs;
ret = recv(client->fd, client->buf + client->bufofs, buflen, MSG_DONTWAIT); ret = recv(client->fd, client->buf + client->bufofs, buflen, MSG_DONTWAIT);
if (ret < 1) { if (ret < 1) {
/* We should have something to read if called since poll set if (!ret)
* this fd's revents status so if there's nothing it means the return;
* client has disconnected. */ if (errno == EAGAIN || errno == EWOULDBLOCK)
return;
LOGINFO("Client fd %d disconnected - recv fail with bufofs %d ret %d errno %d %s", LOGINFO("Client fd %d disconnected - recv fail with bufofs %d ret %d errno %d %s",
client->fd, client->bufofs, ret, errno, ret && errno ? strerror(errno) : ""); client->fd, client->bufofs, ret, errno, ret && errno ? strerror(errno) : "");
invalidate_client(ckp, cdata, client); invalidate_client(ckp, cdata, client);

Loading…
Cancel
Save